Correct a bug occurring when the underlying file object is filling very ...#1
Merged
Merged
Conversation
…ry fast. It is possible that « unused_raw » contains more than one end of stream and start of another. We need to restart the decoder while there are unused data at the end. This caused a strange bug when using that to stream a commoncrawl archive on my server with a good bandwidth, that don't happened on my test computer : zlib.error: Error -3 while decompressing: incorrect header check (in restart_decoder).
|
Sorry for the delay in merging this. Thanks so much for doing the leg work and finding out what the bug was! Your reasoning is sound and I've confirmed it with a test of my own. |
Author
|
Ok, nice. But you haven't merged it ? |
Smerity
added a commit
that referenced
this pull request
Jan 18, 2015
Correct a bug occurring when the underlying file object is filling very ...
|
Gah, somehow totally missed that. My extreme apologies mate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...fast.
It is possible that « unused_raw » contains more than one end of stream and start of another. We need to restart the decoder while there are unused data at the end.
This caused a strange bug when using that to stream a commoncrawl archive on my server with a good bandwidth, that don't happened on my test computer :
zlib.error: Error -3 while decompressing: incorrect header check (in restart_decoder).